Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize raven controllers #1767

Merged
merged 1 commit into from
Nov 6, 2023
Merged

optimize raven controllers #1767

merged 1 commit into from
Nov 6, 2023

Conversation

River-sh
Copy link
Contributor

@River-sh River-sh commented Nov 6, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@openyurt-bot
Copy link
Collaborator

@River-sh: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Nov 6, 2023
@River-sh River-sh force-pushed the optimize_raven_controllers branch from d1ee9e2 to 00a21c6 Compare November 6, 2023 06:33
@River-sh River-sh force-pushed the optimize_raven_controllers branch from 00a21c6 to 9bcd133 Compare November 6, 2023 06:38
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1767 (9bcd133) into master (ea8392b) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 28.31%.

@@           Coverage Diff           @@
##           master    #1767   +/-   ##
=======================================
  Coverage   52.21%   52.21%           
=======================================
  Files         172      172           
  Lines       20877    20877           
=======================================
  Hits        10900    10900           
  Misses       9015     9015           
  Partials      962      962
Flag Coverage Δ
unittests 52.21% <28.31%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nager/controller/raven/dns/dns_enqueue_handlers.go 41.37% <100.00%> (ø)
...rnalservice/gateway_internal_service_controller.go 48.14% <33.33%> (ø)
...r/raven/gatewaypickup/gateway_pickup_controller.go 24.89% <12.50%> (ø)
...n/gatewaypickup/gateway_pickup_enqueue_handlers.go 0.00% <0.00%> (ø)
...yurtmanager/controller/raven/dns/dns_controller.go 29.87% <25.00%> (ø)
...publicservice/gateway_public_service_controller.go 39.14% <50.00%> (ø)
...service/gateway_public_service_enqueue_handlers.go 0.00% <0.00%> (ø)
...rvice/gateway_internal_service_enqueue_handlers.go 0.00% <0.00%> (ø)

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, River-sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Nov 6, 2023
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Nov 6, 2023
@rambohe-ch rambohe-ch merged commit d562a08 into openyurtio:master Nov 6, 2023
@open-digger-bot open-digger-bot bot mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch approved these changes

@Congrool Congrool Awaiting requested review from Congrool

@huangyuqi huangyuqi Awaiting requested review from huangyuqi

Assignees

@rambohe-ch rambohe-ch

Labels
approved approved lgtm lgtm size/L size/L: 100-499
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@River-sh @openyurt-bot @rambohe-ch